- 
                Notifications
    
You must be signed in to change notification settings  - Fork 199
 
latexindent: add extraConfig and disableExtraFiles options #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            trueNAHO
  wants to merge
  3
  commits into
  cachix:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
trueNAHO:latexindent-add-extra-config-and-disable-extra-files-options
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            latexindent: add extraConfig and disableExtraFiles options #514
                    trueNAHO
  wants to merge
  3
  commits into
  cachix:master
from
trueNAHO:latexindent-add-extra-config-and-disable-extra-files-options
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    
  trueNAHO 
      added a commit
        to trueNAHO/git-hooks.nix
      that referenced
      this pull request
    
      Oct 12, 2024 
    
    
      
  
    
      
    
  
Replace the hooks.latexindent.settings.flags option with hooks.latexindent.settings.extraConfig to support arbitrary upstream flags and allow users to override default values. Link: cachix#514
0514a3b    to
    62b9961      
    Compare
  
    
    
  trueNAHO 
      added a commit
        to trueNAHO/git-hooks.nix
      that referenced
      this pull request
    
      Oct 12, 2024 
    
    
      
  
    
      
    
  
Add the hooks.latexindent.settings.disableExtraFiles option to prevent the creation of backup and log files. Upstream refuses adding an option to disable backup and log file creation to protect non-version-controlled users from data loss, despite it being considered unnecessary for those using version control. [1] [2] [3] Considering that Git is the standard in Nix and required for flakes, providing this option is reasonable. [1]: cmhughes/latexindent.pl#145 [2]: cmhughes/latexindent.pl#333 [3]: cmhughes/latexindent.pl#354 Link: cachix#514
    
  trueNAHO 
      added a commit
        to trueNAHO/git-hooks.nix
      that referenced
      this pull request
    
      Oct 12, 2024 
    
    
      
  
    
      
    
  
Enable the hooks.latexindent.settings.disableExtraFiles option by default, aligning with the community consensus that this should be the standard when using version control. Link: cachix#514
    
  trueNAHO 
      added a commit
        to trueNAHO/git-hooks.nix
      that referenced
      this pull request
    
      Oct 12, 2024 
    
    
      
  
    
      
    
  
Add the hooks.latexindent.settings.disableExtraFiles option to prevent the creation of backup and log files. Upstream refuses adding an option to disable backup and log file creation to protect non-version-controlled users from data loss, despite it being considered unnecessary for those using version control. [1] [2] [3] Considering that Git is the standard in Nix and required for flakes, providing this option is reasonable. [1]: cmhughes/latexindent.pl#145 [2]: cmhughes/latexindent.pl#333 [3]: cmhughes/latexindent.pl#354 Link: cachix#514
    
  trueNAHO 
      added a commit
        to trueNAHO/git-hooks.nix
      that referenced
      this pull request
    
      Oct 12, 2024 
    
    
      
  
    
      
    
  
Enable the hooks.latexindent.settings.disableExtraFiles option by default, aligning with the community consensus that this should be the standard when using version control. Link: cachix#514
62b9961    to
    31e108f      
    Compare
  
    Replace the hooks.latexindent.settings.flags option with hooks.latexindent.settings.extraConfig to support arbitrary upstream flags and allow users to override default values. Link: cachix#514
Add the hooks.latexindent.settings.disableExtraFiles option to prevent the creation of backup and log files. Upstream refuses adding an option to disable backup and log file creation to protect non-version-controlled users from data loss, despite it being considered unnecessary for those using version control. [1] [2] [3] Considering that Git is the standard in Nix and required for flakes, providing this option is reasonable. [1]: cmhughes/latexindent.pl#145 [2]: cmhughes/latexindent.pl#333 [3]: cmhughes/latexindent.pl#354 Link: cachix#514
Enable the hooks.latexindent.settings.disableExtraFiles option by default, aligning with the community consensus that this should be the standard when using version control. Link: cachix#514
31e108f    to
    6c76c50      
    Compare
  
    
          Changelogv2: 6c76c50
 v1: 31e108f
 v0: 0514a3b | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This patchset resolves the issue mentioned in #512 (comment) by leveraging the patchset #513 ("latex: reduce installation size and build time").